Re: [PATCH] Keyword hash and Properties as keyword

John Peacock <jpeacock@rowman.com> writes:

> Index: /svn/trunk/subversion/include/svn_subst.h
> ==================================================================
> --- /svn/trunk/subversion/include/svn_subst.h (/svn/trunk/subversion/include/svn_subst.h) (revision 7672)
> +++ /svn/trunk/subversion/include/svn_subst.h (/svn/local/trunk/subversion/include/svn_subst.h) (revision 7672)
> @@ -76,26 +76,34 @@
>
>
> /** Values used in keyword expansion. */
> -typedef struct svn_subst_keywords_t
> -{
> - const svn_string_t *revision;
> - const svn_string_t *date;
> - const svn_string_t *author;
> - const svn_string_t *url;
> - const svn_string_t *id;
> -} svn_subst_keywords_t;
> +typedef apr_hash_t svn_subst_keywords_t;

I haven't looked at the rest of the patch, but this jumped out. This
is an ABI change just as much as changing a function signature and so
it cannot go into 1.1. If you want to put this feature into 1.1. you
will need to use a new type.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org