Re: r9060 mailer.py broke sending author

On Fri, Mar 19, 2004 at 10:13:54AM -0800, Greg Stein wrote:
> On Thu, Mar 18, 2004 at 10:24:09PM -0800, Blair Zajac wrote:
> >...
> > I'm using the description that's been in the mailer.conf.example
> > file for the behavoir:
> >
> > # The default From: and To: addresses for commit messages. If the
> > # from_addr is not specified or it is specified but there is no text
> > # after the `=', then the revision's author is used as the from
> > # address. If the revision author is not specified, such as when a
> > # commit is done without requiring authentication and authorization,
> > # then the string 'no_author' is used. You can specify a default
> > # from_addr here and if you want to have a particular for_repos group
> > # use the author as the from address, you can use "from_addr =".
> >
> > I read this last sentence to mean I can have this:
> >
> > from_addr =
> >
> > in a repository section. Although, rereading it now, it could
> > also mean
> >
> > from_addr = some_address@domain
> >
> > So the comment could be made clearer.
>
> Clearer? Blah. Somebody totally changed the behavior in the code.

Yup. In r9060 cmpilato lost the reference to repos.author during the
change to whack the "override_author" stuff.

A long while ago, the code used to look like:

    self.from_addr = self.cfg.get('from_addr', group, params) or \
                     self.repos.author or 'no_author'

But it now reads:

    self.from_addr = self.cfg.get('from_addr', group, params) or 'no_author'

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org