Re: svn commit: r9085 - in trunk/subversion: include libsvn_subr libsvn_wc

On Tue, Mar 16, 2004 at 06:07:13PM -0500, Greg Hudson wrote:
> Right now, svn_io_set_file_read_write() effectively does a chmod a+w.
>
> I think it would be reasonable to make it do a chmod u+w and treat that
> as a bugfix rather than an API change. It may be a good idea to do this
> in svn 1.0.x, for the marginal security value. (Most of the files we
> set to read-write are then immediately deleted, so it doesn't matter if
> anyone writes to them first; we believe the only exception is the format
> file, and there isn't a lot of utility in seizing the short window of
> writability to write data into the format file.)

Correct... I think I'd rather just leave well enough alone in 1.0.x.
Introduce a new function 1.1.x to "prep for removal" that does nothing
on Unix. But calls read_write on Windows. Put a big fat warning on
read_write about what it really does on Unix and to be careful with it.

> If we want to enable shared working directories (in 1.1), perhaps the
> best option is to introduce a function private to libsvn_wc, which
> invokes svn_io_set_file_read_write only on Windows.

Actually there is code in other sections that would need this same
behavior. I think we should just add a function in 1.1 that gives us a
place to put things that need to be done before a file is removed.
Right now the only OS that needs this is Windows. But if we find other
OSes that need something like this we'll be set.

> (Our ABI rules allow us to do this in svn 1.0.x, but it's a new
> feature, not a bugfix, so we shouldn't do so.)

Unless you consider shared working copies not working to be a bug. :)
(Not saying I do but I'm sure someone will say that they do).

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org