[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Resolve issue 1491: let svnversion_tests.py emit error information on failure

From: <kfogel_at_collab.net>
Date: 2004-03-15 21:05:44 CET

"Erik Huelsmann" <e.huelsmann@gmx.net> writes:
> Index: subversion/tests/clients/cmdline/svntest/actions.py
> ===================================================================
> --- subversion/tests/clients/cmdline/svntest/actions.py (revision 9044)
> +++ subversion/tests/clients/cmdline/svntest/actions.py (working copy)
> @@ -130,7 +130,33 @@
> # make the repos world-writeable, for mod_dav_svn's sake.
> main.chmod_tree(path, 0666, 0666)
>
> +def run_and_verify_svnversion(message, wc_dir, repo_url,
> + expected_stdout, expected_stderr):
> + "Run svnversion command and check it's output"
>
> + out, err = main.run_svnversion(wc_dir, repo_url)
> +
> + if type(expected_stdout) is type([]):
> + compare_and_display_lines(message, 'STDOUT', expected_stdout, out)
> + elif expected_stdout == SVNAnyOutput:
> + if len(out) == 0:
> + if message is not None: print message
> + raise SVNExpectedStdout
> + elif expected_stdout is not None:
> + raise SVNIncorrectDatatype("Unexpected specification for stdout data")
> +
> + if type(expected_stdout) is type([]):
> + compare_and_display_lines(message, 'STDOUT', expected_stdout, out)
> + elif expected_stdout == SVNAnyOutput:
> + if len(out) == 0:
> + if message is not None: print message
> + raise SVNExpectedStdout
> + elif expected_stdout is not None:
> + raise SVNIncorrectDatatype("Unexpected specification for stdout data")

Just one thing:

Is there a cut-and-paste bug here? Shouldn't the second clause be
about expected_stderr, not stdout?

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 15 22:13:55 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.