Re: [PATCH] stdlib removed from svn_types.h

Julian Foad wrote:
>> From: H. Hernan Moraldo <games@moraldo.com.ar>
>>
>> 3- The third option is the one drafted on the patch attached: we don't
>> remove stdlib from svn_types.h, but we stop assuming it is included
>> automatically by including svn_types.h on the other source files. I
>> think this makes for better code, but couldn't know if you agree on
>> this.
>
[...]
> I stopped working on this because it didn't
> really seem worthwhile to do half of the job. If I can't find all of
> the missing and redundant includes, then I am not sure whether it is
> really worth fixing any of them. Maybe it is.

I went to bed and then, after a few minutes, got up again, realising that I'd been too negative. There's no reason not to commit incremental improvements. I would be happy to commit your patch after I have verified it (but I can't do that until next week).

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 12 02:15:10 2004