[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Added feature suppress_modifications to mailer

From: Nicklas Norling <nicklas.norling_at_ifsab.se>
Date: 2004-03-10 16:21:15 CET

> From: C. Michael Pilato [mailto:cmpilato@collab.net]
>
> Nicklas Norling <nicklas.norling@ifsab.se> writes:
>
> > Added the ability to configure parameter suppress_modifications in
> > accordance with the other suppress_* parameters. The example config
> > has the feature as an opt-in. The patch will enable a admin to send
> > out commit emails containing no diff what so ever. This is
> useful in
> > dealing with low-bandwidth sites that still wants the benefit of
> > commit emails.
>
> The patch for issue #1719 solves this problem in (IMO) a much
> better (and scalable) way. Of course, it was my idea, so I'm
> biased. :-) Seriously, check it out -- see if you agree. If
> you don't, I'm all ears.
>

The patch suggested in Issue 1719 looks great. It creates an option
for the admin to make sure that commit emails are as small as possible.

I think it's superiour to mine. That said, 1719 is a much larger
change, while my patch is not as intrusive as it only adds an option
and an option that doesn't have to be set. The original functionallity
will remain no matter what the admin does during an upgrade.

So... if 1719 can't go in because of compatibility problems, I'd like to
suggest mine :)

/Nicke

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 10 16:21:34 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.