Re: Issue #1756 -- import doesn't handle svn:eol-style or svn:keywords

kfogel@collab.net wrote:
> Philip Martin <philip@codematters.co.uk> writes:
>
>>Thus the patch fixes the "normal" use case and makes commit and import
>>have the same behaviour. In the "abnormal" case commit and import are
>>different whether or not the patch is applied, the patch merely
>>changes the nature of the difference.
>
> I think Julian's point is that the import now imports something other
> than the file's contents, in such a way that the original contents
> can't be reliably reproduced -- and that 'import' is the operation for
> which such behavior is least appropriate.
>
> I'm not sure I have a strong opinion one way or the other, just trying
> to summarize his position for clarity (or possibly I've got it wrong,
> in which case he'll correct me).

Thanks Karl. That summary is not inconsistent with my reasoning, but is not my main line of argument :-)

What I didn't say explicitly is that I am wholly in favour of what I believe was the intent of this patch, and was merely pointing out that the patch is not quite right: it should not request repair (which is just a matter of changing a "TRUE" to "FALSE"). With that modification, I would be happy with the patch and happy for it to be ported into 1.0.1 if other people think it is appropriate. I won't vote +1 because I haven't tested it, and I still think it has a bit of a flavour of "enhancement" to it, but am now being persuaded that it is pretty much a bug fix and quite an important one, so would vote at least +0.

The reason I voted -1 is because it appeared that nobody had noticed the inconsistency and it looked as if three reviewers were going to agree that the patch is perfect, and then we would merge it and never look at it again.

If someone will change that "TRUE" to "FALSE", I'll remove my veto. I'll do it if you like. Any reason not to?

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 9 14:30:20 2004