[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Remarks on backports from STATUS

From: Erik Huelsmann <e.huelsmann_at_gmx.net>
Date: 2004-02-27 20:43:21 CET

Reviewing the changes in STATUS for backporting to 1.0.x I found the
following issues:

* r8839 (import doesn't handle eol-style and keywords)
   the changed function send_file_contents leaks a temporary file when and
error
   occurs between the creation of the temp file and temp file cleanup. I
think
   an additional commit should solve that before merging this to 1.0.x.

* r8551 (cause blame to bail on binary files)
  This revision adds a new error code which I think is inappropriate for
micro
   releases due to our forward and backward compatibility restraints on the
API.
   For this reason I've put a -1 in status. Returning another error until
1.1 would
   solve this issue as far as I'm concerned.
   I think SVN_ERR_ILLEGAL_TARGET is somewhat cryptic but gets closest to
being reasonable.

bye,

Erik.

-- 
GMX ProMail (250 MB Mailbox, 50 FreeSMS, Virenschutz, 2,99 EUR/Monat...)
jetzt 3 Monate GRATIS + 3x DER SPIEGEL +++ http://www.gmx.net/derspiegel +++
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 27 20:42:39 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.