Re: viewcvs not working anymore on windows with current version o f tr unk due to changes in apr.i

On Wed, Feb 25, 2004 at 07:54:39PM +0100, Marc Haesen wrote:
> This patch not really solves the problem. The reason is that APR_INT64_T_FMT
> is only defined if you pass -DWIN32 on the command line of swig, which is
> not the case in the automatically generated project files. But if I change
> this, swig gives a syntax error in apr.h for the following declaration:
>
> typedef unsigned __int64 apr_uint64_t;
>
> If I remove this line from apr.h, it is OK. (For swig at least, because with
> this line removed apr itself will not build anymore)
> The syntax error occurs both in version 1.3.19 and 1.3.21 of swig.

So what you're saying is SWIG doesn't like APR's header files on
Windows. Which means there's also a SWIG bug.

Could you give the specific error SWIG is giving you?

Can you please post your apr.h file?
 
> I am also not really sure if swig handles the || operator in the #if
> statement correctly.

It should.

We should always just handling things like this:

#if <format conditions for 64-bit platforms we know about>
  /* Use long */
#elsif <format conditions for 32-bit platforms we know about>
  /* Use long long */
#else
  /* Use long long since it should always be 64-bit but will
     emit warnings on some platforms. */
#endif

That gives us a fall through case for other platforms with weird
formats.

> I saw that you already committed svn_types.i, but a similar problem exists
> in apr.i, which is not changed yet.

Yup I'll do that one myself here in a sec.

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org