Ben Reser <ben@reser.org> writes:
> You changed the function signature. So this isn't going to go into
> 1.0.x. You'd have to make a svn_client_blame_verbose() to put it in
> 1.0.x.
I think you mean 1.1.x, not 1.0.x?
Also, we should emphasize that it's not the end of the world if a
patch contributor isn't aware of Subversion's release compatibility
guidelines (Ben G, see the HACKING file if you're curious). We can
easily take care of trivial things like renaming the API; the
important thing is the functionality.
I've been holding off responding to this patch until I get a chance to
ponder exactly what should be in 'blame -v' and how it might look, and
if there are any other extensions we want to consider in the future.
(For example, one realization is that when Subversion downloads the
raw blame information for rev R, it actually gets enough information
to do 'svn blame' for *all* "ChangedRevisions" <= R for that file.
This could be really interesting if you're looking for blame info on
content that you suspect might be deleted before R. Showing all
ChangedRevs <= R might be a useful interpretation of 'blame -R'.)
Anyway, the question is complex enough that responding to the patch
immediately wasn't possible (for me), sorry about that. Sander Roobol
won't let it slip away from the issue tracker, though.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 16 06:30:55 2004