[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r8562 - trunk/subversion/svnadmin

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2004-02-06 00:23:03 CET

cmpilato@tigris.org wrote:
> Author: cmpilato
> Date: Thu Feb 5 10:14:46 2004
> New Revision: 8562
>
> Modified:
> trunk/subversion/svnadmin/main.c
> Log:
> * subversion/svnadmin/main.c
> (subcommand_setlog): Pass "svnadmin" as the username when folks use
> 'svnadmin setlog'.

Why? I'm not saying it's wrong, just asking because no reason is apparent to me, and I regard the "###" as meaning "we really should fix this soon". (Is that how other people interpret "###"?)

The sort of thoughts that spring to mind are: Is there a precedent of using a hard-coded user name of "svnadmin" elsewhere? Does it matter if it is indistinguishable from a genuine user name "svnadmin"?

My guess is that this is just a simple way of making an error message or something more friendly. Probably no harm in it.

- Julian

> Modified: trunk/subversion/svnadmin/main.c
> ==============================================================================
> --- trunk/subversion/svnadmin/main.c (original)
> +++ trunk/subversion/svnadmin/main.c Thu Feb 5 10:14:46 2004
> @@ -732,9 +732,10 @@
> }
> else
> {
> + /* ### hard-coding "svnadmin" as the user-name. */
> SVN_ERR (svn_repos_fs_change_rev_prop
> (repos, opt_state->start_revision.value.number,
> - NULL, SVN_PROP_REVISION_LOG, log_contents, pool));
> + "svnadmin", SVN_PROP_REVISION_LOG, log_contents, pool));
> }
>
> return SVN_NO_ERROR;

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 6 00:22:05 2004

This is an archived mail posted to the Subversion Dev mailing list.