Re: svn commit: r8539 - trunk/tools/hook-scripts

Branko Čibej <brane@xbc.nu> writes:

> >>I think I saw a patch that did something like that the other day...
> >>
> >Do you mean that one:
> >
> >http://www.contactor.se/~dast/svn/archive-2004-01/0062.shtml
> >
>
> Yup, that's the one. Well Mike, do you want to make this a 1.0
> candidate? :-)

In a modified form, perhaps. I don't like that propchanges are
triggered by '--revprop' which much be the first argument. I'd rather
see a subcommand syntax like our binaries use:

  $ commit-mailer.py commit REPOS-DIR REVISION [CONFIGFILE]
  $ commit-mailer.py revprop REPOS-DIR REVISION AUTHOR PROPNAME [CONFIGFILE]

But other than yet, I love the patch. Dunno if I wanna hold up a 1.0
release for it. Also, there's a major downside to shipping *only*
commit-mailer.py -- the bindings requirement.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 30 16:10:39 2004