Re: A new look at the apr_off_t problem

Greg Hudson wrote:

> 1. The blame callback uses an apr_off_t for the line number. It is
> easy to change this to use an apr_uint64_t instead. (The current
> #1710 patch does this.)
>
>
Why does it use a file-offset type for a line-number parameter? That's
utter nonsense. It should simply use apr_uint32_t; after all, "svn
blame" (as currently implemented) is only useful for text files, and I'l
like to see the genius who can keep track of more than 4 billion lines
of text. I don't think even a Greek demi-god hero could handle that.

And if, for some obscure reason, 4 gig isn't enough, just use
svn_filesize_t. I can't imagine blame needing negative line numbers.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org