[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r8343 - trunk/subversion/libsvn_ra_svn

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-01-16 19:30:29 CET

On Fri, 2004-01-16 at 13:20, ghudson@tigris.org wrote:
> * subversion/libsvn_ra_svn/cram.c (compute_digest): Use an unsigned
> char array for the secret. Patch from Philip Martin.

The bitwise operations performed on secret are all xors, so there should
be no semantic problem with them being (possibly) signed char. So, it's
mainly an issue of warnings with pickier compilers. Do people think
that's important enough for a 1.0 pullup?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 16 19:31:26 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.