Re: review/comments on issue #1681

kfogel@collab.net wrote:
> I was reviewing the issue #1681 patch, and found a couple of very
> minor things. Not coding errors, but just wanted to set these down
> here so we'd remember, and have a mail to refer to from the issue.
>
> After the review is a bit of discussion.
>
>>Log message:

I don't know how I did it, but I managed to put the log message for the
first version of the patch in the issue tracker. I've put the correct
log message in there now.

> All good (except for the "-F"). Of course, the book needs updating
> too. This is part of a much larger bunch of book changes (most of
> which Ben, Mike, and Fitz are doing on their own time anyway), so
> there will be a chance for this to get tweaked appropriately. Just
> noting it here.

I think that the documentation will be simpler if anything. That's the
point of the change, i.e. to make svnserve more user friendly. I'd be
happy to update the book as well, but I fear that the quality of my
english is not high enough.

>>+ if (run_mode == run_mode_none)
>> {
>>+ fprintf(stdout, "You must specify one of -d, -i, -t and -X!\n");
>>+ usage(argv[0]);
>>+ }
>
> Shouldn't that be "or" instead of "and" in the usage message?

Thanks! I've made a note in the issue and the STATUS file.

> Can we think of any upgrade strategy that would avoid such trouble?

I can't think of a better way than to change it now, before it's too
widely used.

/Tobias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jan 8 13:13:38 2004