Justin sent this to me privately, but I thought it was worth
forwarding to the list, and he was okay with that:
Justin Erenkrantz <justin@erenkrantz.com> writes:
> Let me reiterate a key point of the review process from httpd: you
> *never* explicitly blame anyone if a bug is later found in a review
> that others +1ed.
>
> It is incredibly bad form and only serves to get people riled up. You
> just deal with the fact that the patch is bad and move on.
>
> Do I think it sucks that I missed the doc string? Sure, but I had
> nothing but the best of intentions here (which I think somehow got
> lost here). Yet, that's why we require 3 +1s - to minimize people
> missing things. 3 people giving their best effort to the review the
> changes *are* going to catch things like this.
>
> Yet, I'm a 'big boy' and can take it. But, I wonder if others are
> probably going like, 'Shit, we're not going to review anything now'
> because of your comments.
>
> Just a word to the wise. If we want the review process to succeed,
> we're going to have make this review process friendly as possible,
> not confrontational. If it becomes confrontational, it'll fail
> spectacularly.
Hmm, he's right -- my original mail was not very constructive.
A different sort of post might have been in order, to alert people
(who may not follow every thread on the list) that they might want to
either change their vote, or quickly review the new fixup patch. But
that could be done less confrontationally and more casually than I did
it.
So, sorry, no chilling effect on future reviews intended, and I hope
none taken. If similar situations come up (and they probably will) I
will post more constructively or not at all :-).
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 29 22:50:49 2003