Re: PATCH: Stop defining identifiers in APR's name space

kfogel@collab.net wrote:
> Julian Foad <julianfoad@btopenworld.com> writes:
>
>>I believe this was mentioned as something that is needed before 1.0.
>>
>>Should I commit it?
>
> I think it's a good idea to get it on trunk, at the very least. Not
[...]
>>Stop defining Subversion identifiers in APR's name space.
[...]
> Very minor nit: the usual style is to put the new name in parens, as
> in
>
> (svn_sort_hash): New name for apr_hash_sorted_keys.

OK - will do.

> But also, Greg Stein made an interesting suggestion, quoted in the
> issue (#1644):
>
> > If we're pretty sure these will get into APR, we could name them
> > svn__apr_foo and SVN__APR_FOO, make sure there are no doxygen
> > comments for them, and note in the header files that they're for
> > internal use only. Then it should be reasonably safe to remove
> > them from the libraries in the future.
> >
> > If we think some of them won't make it into APR, then we should
> > pick names we're comfortable with supporting.
>
> I'm not sure, right now, which of these are likely to make it into
> APR, but its seems prudent to start out by using auto-deprecated
> names. We can always promote them to real names in a later release
> once we know what's happened in APR.

Ah, yes. Acually if we're not absolutely sure they will go into APR, it's wrong to have "APR" in their names, so that should just be "svn__foo" or, in svn_sorts.h, "svn_sort__foo".

> Regarding svn_sort_hash(), do we want to also rename svn_item_t to
> match?

Yes, though it's not so important because it's not part of another project's name space, just the wrong part of our own.

So I think we want:

svn_sort__hash
svn_sort__item_t

Yes?

Unfortunately I will be pretty much off-line from tomorrow until about 6th January, so I probably won't have time to do this now. Anyone please feel free to continue this.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Dec 20 00:06:04 2003