[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: possible file/dir handle leaks

From: Steve King <ichselbst_at_gmx.ch>
Date: 2003-12-16 22:31:18 CET

Erik Huelsmann wrote:

> The files are also closed when the pool is cleared. There is no need to
> destroy the pool for that. Generally it is a good idea to clear pools if you
> expect a long period of inactivity. In case of TSVN I would create a pool per

I guess I'll have to clear the pool then. But it won't prevent me from
copying all the data I still need to another pool - or is the data not
cleared when the pool is cleared?

> menu action and another for long lived data between menu actions. (But you
> probably know that; I'm not familiar with TSVN code...)

TSVN has two parts: the "Proc" part where all the commands from the
context menu are executed and the "Shell" part which is a shell
extension and is responsible for the icon overlays and the context menu
itself. The proc part is a normal exe which terminates after each
command. Only the shell part stays in memory as long as a desktop is active.
So the task of finding the handle leak can be reduced to
svn_client_status() because that's the only function from the subversion
library the shell extension part ever uses (apart from some apr_hash
functions and svn_path_internal_style).

I'll try some tests tomorrow with Lübbe as soon as I changed the code so
that the pool is cleared after each call to svn_client_status().

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 16 22:32:35 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.