[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: API issues we might want to solve for 1.0

From: <kfogel_at_collab.net>
Date: 2003-12-15 21:04:55 CET

Greg Hudson <ghudson@MIT.EDU> writes:
> > #5: svn_ra_init_ra_libs and friends use a void * baton instead of an
> > opaque type.
> > IMPACT OF PROBLEM: The interface is needlessly non-type-safe.
> > DIFFICULT OF FIX: Minor.
>
> I took a look at this and found that in every single case except for
> one (svn switch --relocate), we initialize the ra baton, use it once
> immediately, and discard it.
>
> So I'm thinking, maybe we don't need an svn_ra_init_ra_libs. What do
> other people think?

In other words, svn_ra_get_ra_library() would just do internally
whatever it is that svn_ra_init_ra_libs() does right now, so that
svn_ra_get_ra_library() wouldn't need to take the baton argument at
all?

What is the exception in 'svn switch --relocate'? In the code of
svn_client_switch(), it seems the ra_baton is used in exactly the same
way it is everywhere else...

There does seem to be a bit of an exception in libsvn_client/diff.c,
where the ra_baton is passed as an argument to two successive calls to
single_file_merge_get_file().

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 15 21:54:14 2003

This is an archived mail posted to the Subversion Dev mailing list.