Greg Hudson <ghudson@MIT.EDU> writes:
> As it's much easier to make API changes before 1.0 than after, here
> are a list of issues we might want to solve soon. The first three
> seem important; the rest are just unfortunate foibles (except for #6,
> but that would require a serious push to fix). Many of these have
> received attention in the past, but time marched on without anyone
> fixing them.
>
> #1: We define symbols in the APR namespace:
> In svn_sorts.h: apr_hash_sorted_keys
> apr_array_prepend
> In svn_types.h: APR_ARRAY_IDX
> APR_ARRAY_PUSH
> apr_atoui64
> IMPACT OF PROBLEM: We're not very sociable, and might conflict with
> a future version of APR which includes these symbols.
> DIFFICULTY OF FIX: Depends on how we fix them.
Follow-up to this that's been on my TODO list (though anyone can do it
if they so desire):
Change APR_ARRAY_PUSH definition from
#define APR_ARRAY_PUSH(ary,type) (*((type *)apr_array_push (ary)))
to
#define APR_ARRAY_PUSH(ary,type,item) \
(*((type *)apr_array_push (ary))) = item
And for what it's worth, I agree with the other assessments in your
mail (though I'm not terribly bothered about the log_receiver taking
changed_paths as a hash instead of an array).
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Dec 12 17:34:46 2003