Re: svn commit: rev 7956 - in trunk: . subversion/libsvn_subr

> dionisos@tigris.org wrote:
> > Author: dionisos
> > Date: Mon Dec 8 12:19:26 2003
> > New Revision: 7956
> [...]
> > Modified: trunk/HACKING
> [...]
> > + * Please wrap your lines in such a way that the message text (if you
>
> > + supply any) so that the message appears on the start of a new
> line.
>
> Oops - too many words.

Oops indeed.

> > + Like:
> > +
> > + svn_error_createf (SVN_ERR_FOO, NULL,
> > + "Authorisation failed for '%s'", url);
>
> I don't see the point of making this a formal convention. It often
> happens naturally, but if an error message is very short, why not put it
on the
> end of the first line; and what if the error message is not a simple
> constant string but, say, a function call like apr_psprintf(pool,
"Format", args)
> or an expression like (query ? "Query" : "Other") ?

Well, I did, because Greg Hudson just changed the code to adhere to this
convention. If it is not possible ot do it this way, then it isn't. I still
think it's good to mention that it is the general idea.

bye,

Erik.

-- 
+++ GMX - die erste Adresse für Mail, Message, More +++
Neu: Preissenkung für MMS und FreeMMS! http://www.gmx.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org