Re: Bug in mod_dav_svn ? svn:mime-type not respected ?

On Sun, 2003-12-07 at 10:02, C. Michael Pilato wrote:

> Hm. It looks like that chunk of code should be accepting both VERSION
> and REGULAR resource types. I've got other patches in progress, and
> no time to test a fix, but I wonder what would happen if that
> conditional became:
>
> if ((mimetype == NULL)
> && ((resource->type == DAV_RESOURCE_TYPE_VERSION)
> || (resource->type == DAV_RESOURCE_TYPE_REGULAR))
> && (resource->info->repos_path != NULL))

Oops, yup, Philip is right. It's a bug in r7797, which was a fix for
issue #1606. We were overzealous in our segfault protection.

I'm able to reproduce the bug with my 0.34 mod_dav_svn server, and
Mike's is correct. It fixes the bug. Committed in r7955.

Hmmm, how would one write a regression test for this?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 8 18:41:57 2003