Re: Just to be sure: file closing on pool cleanup?

Erik Huelsmann wrote:

>Just to be sure that I am doing the right thing:
>
>because of the change I am doing from apr_file_write_full to
>svn_io_file_write_full the latter of which can be wrapped in SVN_ERR, I am wondering if I
>can throw out the apr_file_close on an error from apr_file_write_full. Greg
>Hudson said over IRC that pool cleanup should take care of clearing files. Can I
>indeed count on that, thus wrapping svn_io_file_write_full in SVN_ERR, or
>should I catch the error, close the file and then throw the error up the call
>chain?
>
>
Pool cleanup will close the file, but we should call apr_file_close
anyway, because we don't want open file handles hanging around until
somebody happens to clear the pool.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org