Re: PATCH: Errors that are ignored but should be cleared

Julian Foad <julianfoad@btopenworld.com> writes:

> I also found the following, but we might as well evaluate the "###
> ... todo" comments and do the right thing while we are thinking
> about it, so what is the right thing? Just clear and ignore the
> error, or not?
>
> ~/src/subversion> grep -C3 "svn_repos_abort_report" subversion/mod_dav_svn/update.c
> if (! SVN_IS_VALID_REVNUM (rev))
> {
> /* ### This removes the fs txn. todo: check error. */
> svn_repos_abort_report(rbaton);
> serr = svn_error_create (SVN_ERR_XML_ATTRIB_NOT_FOUND,
> NULL, "rev");
> return dav_svn_convert_err(serr, HTTP_INTERNAL_SERVER_ERROR,
> --

In all these cases there is some error more important than the result
of svn_repos_abort_report(). So, perhaps just do:

   svn_error_clear(svn_repos_abort_report(rbaton));

It's not as if the user is going to be able to do a darned thing about
a transaction that didn't get cleaned up from alllll the way across
the network. -)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 26 05:28:28 2003