[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Illegal characters in filenames

From: Peter Nordlund <Peter.L.Nordlund_at_telia.com>
Date: 2003-11-24 20:53:47 CET

I see that a related issue has been discussed in the thread
concerning filenames containing accents.

I installed subversion 0.25, 0.33.1 and latest code from trunk
as of 2003-11-23 All of them seems to behave identically with
respect to my testcase (see below).

I have to tell you that I am a newbie with respect to svn, so
I might have gotten a few things wrong concerning both the installation
and the use of svn. So I would be glad if someone skilled with svn
could verify that the testcase I submit in the attached tar-file
indicates an undesirable behaviour from svn.

I have a file with some probably illegal characters in the filename.
XmlApplicationLoaderException.java\001\027
(I imported a large bunch of files, and it took me quite a while to
track down
which file that was causing me trouble, and I think it is a quite
reasonable use-case
to import a bunch of files with uncertain quality.)
"svn co" exits with an error message which is not informative enough for me,
and certainly not for an every-day-user:
    subversion/libsvn_subr/xml.c:362: (apr_err=130003)
    svn: XML data was not well-formed
    svn: not well-formed (invalid token) at line 3

I think it would be desirable with some error message mentioning the
filename
of the bad file (the file being processed when the error occurs)
(I understand that this might be tricky, since the filename itself seems
to be bad).

Now, if it so that the file with the naming as provided in the attached
tar-file should not be coped with by svn, then I suggest the following
improvements if possible:

- With respect to usability I think that this problem should be taken
  care of earlier on if possible.

  I suggest that this bad file naming should be detected already in the
  "svn import" command, not as now: "svn import" seems to be ok,
  but "svn co" bails out with an error message.

     In my opinion a file that has a name that is not acceptable by "svn
co" should not
     be accepted by "svn import". Am I right? Or maybe there is a way of
doing the
     import so that this problem is detected?

Best Regards,
Peter Nordlund

Some technical details and instructions for testcase comes below.
-------------------------------------------------------------------------
# Output from uname -a:
Linux peternl.computervision.se 2.4.22-10mdk #1 Thu Sep 18 12:30:58 CEST
2003 i686 unknown unknown GNU/Linux

# I run Mandrake 9.2 and installed with:
./configure --enable-dav --enable-so --enable-maintainer-mode
--enable-ssl --enable-deflate --with-apr=/usr/local/apache2
--with-apr-util=/usr/local/apache2
make
su
make install
svnserve -d

tar zxvf testcase.tgz

# Logged in as root (I did so to get going, someone skilled could do it
some other way.)
rm -rf /usr/local/svn/repos-test-works
svnadmin create /usr/local/svn/repos-test-works
cd orig-code-works
svn import file:///usr/local/svn/repos-test-works # Works ok.
cd ..
svn co svn://localhost/usr/local/svn/repos-test-works works # Works ok.

# The above works ok!

rm -rf /usr/local/svn/repos-test-fails
svnadmin create /usr/local/svn/repos-test-fails
cd orig-code-fails
svn import file:///usr/local/svn/repos-test-fails # Works sort of, no
error msg.
cd ..
svn co svn://localhost/usr/local/svn/repos-test-fails fails # Fails.

# "svn co" ends with:
subversion/libsvn_subr/xml.c:362: (apr_err=130003)
svn: XML data was not well-formed
svn: not well-formed (invalid token) at line 3

###################################################
If you have any solution to this problem, please mail
Peter.L.Nordlund@telia.com.

Also mail me if you want me to send the testcase, I have not understood
if this mail-list
archive handles attachments.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon Nov 24 21:19:29 2003

This is an archived mail posted to the Subversion Dev mailing list.