[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] : issue #1584 : Prevent revision props on files/dirs

From: David Kimdon <david_at_kimdon.org>
Date: 2003-11-19 22:35:43 CET

On Tue, Nov 18, 2003 at 09:35:42PM +0100, Martin Furter wrote:
> >
> > + const char *revision_props[] =
> > + {
> > + SVN_PROP_REVISION_ALL_PROPS
> > + NULL,
> > + };
>
> ... and add it here after SVN_PROP_REVISION_ALL_PROPS.
>
> Perhaps a little bikesheddy, but i think the revision_props[] looks more
> C-like when there's comma.

Good point, it does look ugly with nothing between the macro and the
NULL. FYI, I just commit the change below, removed the NULL which was
silly, and now it looks quite pretty, IMO.

Thanks,

-David

Index: subversion/include/svn_props.h
===================================================================
--- subversion/include/svn_props.h (revision 7781)
+++ subversion/include/svn_props.h (working copy)
@@ -276,6 +276,14 @@
  */
 #define SVN_PROP_REVISION_ORIG_DATE SVN_PROP_PREFIX "original-date"
 
+/*
+ * This is a list of all revision properties.
+ */
+#define SVN_PROP_REVISION_ALL_PROPS SVN_PROP_REVISION_AUTHOR, \
+ SVN_PROP_REVISION_LOG, \
+ SVN_PROP_REVISION_DATE, \
+ SVN_PROP_REVISION_ORIG_DATE,
+
 /** @} */
 
 
Index: subversion/libsvn_client/prop_commands.c
===================================================================
--- subversion/libsvn_client/prop_commands.c (revision 7781)
+++ subversion/libsvn_client/prop_commands.c (working copy)
@@ -57,6 +57,28 @@
 }
 
 
+/* Check whether NAME is a revision property name.
+ *
+ * Return TRUE if it is.
+ * Return FALSE if it is not.
+ */
+static svn_boolean_t
+is_revision_prop_name (const char *name)
+{
+ int i;
+ const char *revision_props[] =
+ {
+ SVN_PROP_REVISION_ALL_PROPS
+ };
+
+ for (i = 0; i < sizeof (revision_props) / sizeof (char *); i++)
+ {
 

>
> Martin
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 19 21:44:48 2003

This is an archived mail posted to the Subversion Dev mailing list.