[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Take 2: Modified export behavior

From: <kfogel_at_collab.net>
Date: 2003-11-18 16:09:45 CET

John Szakmeister <john@szakmeister.net> writes:
> The next problem I ran into was time-stamping the file. In an export
> from the repository, you'd get the last committed time stamps. So, I
> did the same for export... except for one problem, what do I do with
> locally modified files? At the moment, I'm making a call to
> svn_wc_status() and checking text_status or props_status != normal.
> If either has been modified, then I'm pulling the time stamp from the
> WC file and applying it to the export.
>
> Then I started thinking, that if I copied the modified file times from
> the working copy, that someone might use that information to determine
> what had changed. Then I got to wondering whether or not the
> $LastChangedRev$ should reflect the fact that a file is locally
> modified (perhaps something like $LastChangedRev: 2+ $), as well as
> changing $LastChangedBy$ to reflect the current user.

Whew.

First, the timestamps: I'd say if the file's text has been modified
locally, then the timestamp should be that of the working file. If
only props -- even a keyword or eol prop -- are modified, then use the
committed time, because exports do not preserve properties (even
though they may preserve keyword or eol effects, they don't preserve
the actual properties).

As for the keyword expansions: you can't count on the "current" user
having any meaning in the repository username space. The system
username might be totally unrelated to the usernames used by the
repository. So $LastChangedBy$ should be unaffected, IMHO.

As for the rev, if you want to put a "+", I think that's okay, but
it's sort of a bikeshed to me... :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 18 16:53:19 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.