Re: svn commit: rev 7770 - trunk/subversion/tests/clients/cmdline/svntest

Julian Foad <julianfoad@btopenworld.com> writes:

>> It's not a good thing, period. The repository loader only depends on
>> the
>> dumpfile parser (which is pretty simple and stable) and libsvn_fs, which
>> has its own exhaustive tests. "svn import", on the other hand, depends
>> on all the libraries. Therefore, using "svnadmin load" to prepare the
>> initial tree give us much better confidence that the tests start in a
>> consistent state than using "svn import".
>> Please revert this change.
>
> Reverted in r7781. Your reasoning seems concise and appropriate so
> I quoted it in the log message; I hope that's OK.

I don't really understand. We still use import, that's how we create
the dumpfile that gets loaded. Is using import/dump/load really that
much of an improvement over just using import?

Another idea: the dumpfile is less than 4K. How about versioning it,
droping the import/dump and simply loading the versioned dumpfile?
(This would have the effect that all the commit tests would use the
same Last-Changed-Date for the loaded revisions, I don't know if that
matters.)

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org