kfogel@collab.net wrote:
>Nor am I bothered by the prospect of a couple of system-dependent
>conditionals in repos.c:create_hooks(). It seems a small price to pay
>to solve issue #1601.
>
>
I don't like this at all. First of all, making .bat files universally
work as hook programs on Windows hasn't happened yet, and could be a bit
of a problem. But I'm much more worried about the idea of hard-coding
program paths at compile time. Whilst this may be standard (if broken!)
practice on Unix, it will _not_ work on Windows because there's no such
thing as a standard install location.
But that's irrelevant. We can make a small hook _program_ that's called
the same way on all platforms and install that. Take the code from
"svnadmin deltify" and move it to "svndeltify", and install that in the
repository (using a symlink on Unix, for all I care). Locating this
program at "svnadmin create" time is no problem at all -- just require
it to be installed in the same directory as svnadmin. Then add a bit of
code to the hooks launcher that runs this in the background -- using
portable APR calls -- at the same time as the post-commit hook. Then, if
the admin prefers to deltify in a cron job, they just remove the
svndeltify instance from the hooks directory.
>I'll do this, with a little help for some of the Windows stuff, if we
>agree it's the thing to do. I just want to make sure I'm not missing
>any serious problems.
>
>
There are no conceptual problems that I see, if that's what you mean.
But I really, really believe this is not something we should leave to
scripting, and if we can avoid platform-specific code, so much the better.
--
Brane Čibej <brane_at_xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 15 09:06:22 2003