[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

send_xml returns void in mod_dav_svn/update.c?

From: <kfogel_at_collab.net>
Date: 2003-11-10 23:08:43 CET

Greg, any idea why we ignore the result from apr_brigade_vprintf() and
just return void from send_xml() in this mod_dav_svn/update.c code:

static void send_xml(update_ctx_t *uc, const char *fmt, ...)
{
  va_list ap;

  va_start(ap, fmt);
  (void) apr_brigade_vprintf(uc->bb, ap_filter_flush, uc->output, fmt, ap);
  va_end(ap);
}

?

Almost all callers of send_xml() return (svn_error_t *), so if it
returned an error we would have a way to propagate that error.

But, there's probably some reason it's void?...

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 10 23:50:17 2003

This is an archived mail posted to the Subversion Dev mailing list.