[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 'svn st' segfaults

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2003-11-06 14:43:04 CET

On Nov 6, 2003, at 7:53 AM, Osku Salerma wrote:

> How to make subversion 0.32.1 crash:
>
> cd <random workspace>
> touch <random versioned file>
> chmod 0 <same random versioned file>
> svn st
> Segmentation fault

Actually, we were trying to compose two errors together when one of the
was NULL... Note that I can't make the error occur in my svn working
copy, but in my serf working copy it does happen. I suspect it's
related to EOL conversion or keyword substitution or something. Here's
a patch that fixes the problem. If someone wants to glance at it, run
it through make check, and maybe commit, feel free. I'm late for work
already ;-)

-garrett

* subversion/libsvn_wc/questions.c
   (svn_wc__versioned_file_modcheck): don't compose a NULL error.

Index: subversion/libsvn_wc/questions.c
===================================================================
--- subversion/libsvn_wc/questions.c (revision 7646)
+++ subversion/libsvn_wc/questions.c (working copy)
@@ -220,7 +220,8 @@

    if (err)
      {
- svn_error_compose (err, err2);
+ if (err2)
+ svn_error_compose (err, err2);
        return err;
      }

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 6 14:44:07 2003

This is an archived mail posted to the Subversion Dev mailing list.