[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue #897: libsvn_client

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-11-06 08:06:23 CET

Erik Huelsmann wrote:

>Hmm, Now that you mention those. I think I should have indeed picked up on
>that. I will revise the patch and resubmit when it is ready.
>
>One problem remains: I raised the question on IRC, bug Greg Hudson said it
>should not be a problem, since there are no long error messages: the issue
>discusses wrapping at 70 columns. We do have long error messages (when filenames
>are %s-ed in) and we do have messages with multiple lines. Is it an option
>to svn_error_quick_wrap the extra lines into other error structures?
>
>
If we know that the message has several "logical" lines (as in the
checksum mismatch example), then IMHO we should use
svn_error_quick_wrap. Any other kind of wrapping sould have to be done
by the client, since the client knows best how to display the errors.
Yes, the cmdline-specific svn_handle_error is in libsvn_subr, but that's
a special case and GUI clients can do anything they like.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 6 08:07:01 2003

This is an archived mail posted to the Subversion Dev mailing list.