[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Preliminary patch for adding external locking filecode to svn_repos_open]

From: Files <files_at_poetryunlimited.com>
Date: 2003-11-04 06:38:40 CET

David,

Check out this one.

I think you'll find it avoids a few pitfalls yours will have as well as
sticking to your intent. Yours I think you'll find is calling the locking
mechanism before the repository information is initialized. Whereas if you
wait to call the locking info, you can leverage the repository configuration
itself.

If you like it great. If not, you know what to do with it.

I found a few things in it that might cause problems in the config_read
section too.

Have a look.

The lock file uses a section called lock and a option called external
(true/false/yes/no etc).

This not only attempts to create the lock files, but also attempts to open the
repository in exclusive mode.

Do you think this is overkill?

P.S. The code never evaluates the lock information more than once per run.

-- 
Shamim Islam
BA BS
David Kopp said:
> Doh!
>
> I forgot to attach the diff file to the last message. Here it is.
>
> David
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Tue Nov 4 06:39:25 2003

This is an archived mail posted to the Subversion Dev mailing list.