[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: lock:// protocol hacked in

From: Files <files_at_poetryunlimited.com>
Date: 2003-11-03 20:45:57 CET

David, and Greg,

The included patch file contains David's locking algorithm merged in with your
(Greg's) specific request to piggyback on ra_local.

The semantics of opening the repository is left to the generic ra_local
behavior once the lock is obtained.

If you guys like it, great. If not, it was a fun tweak.

David, let me know if you have any issues. I can't get subversion to build
right now, but it compiles this part correctly as far as I've been able to
test.

If you notice in the included patch, I've added some spaces, and where you had
a value that was only being tested but never used again, I've used to the C
idiom of embedding the test in the if statement as is consistent from what
I've seen in subversion.

Also, the return values of true/false functions are svn_boolean_t.

And finally, returns are returned instead of holding a value just to return it.

Lastly, there is only one error code w/ the LOCK failure - when attempting to
obtain the lock.

Change anything you like. Hope this gives you a leg up.

Notice, it does not impact the build system at all.

And any changes in ra_local behavior will be propagated with little or no fuss.

-- 
Shamim Islam
BA BS
Greg Hudson said:
> On Mon, 2003-11-03 at 13:07, David Kopp wrote:
>> If it was put in repos.c, I would have to add code to check the
>> repository properties, and only do this if the appropriate property was
>> set. Are there any examples of this? And how do you set the repository
>> property to begin with?
>
> We don't have any generic repository configuration right now (I just
> added a conf/svnserve.conf, but it's specific to svnserve), but for the
> purposes of a local hack, you could just check for the existence of a
> file.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon Nov 3 20:46:45 2003

This is an archived mail posted to the Subversion Dev mailing list.