Re: [PATCH] Autotools fix

Scott Moynes <smoynes@nerdnest.org> writes:

> svn-config was erroring out due to bad escaping in the neon.m4 macro
> when building with neon in the subversion source tree:
>
> $ ./svn-config
> ./svn-config: line 1: abs_builddir: command not found
> ./svn-config: line 1: abs_srcdir: command not found

I don't get that error, what OS/shell are you using?

> * build/ac-macros/neon.m4: Fix variable escaping
>
> Index: build/ac-macros/neon.m4
> ===================================================================
> --- build/ac-macros/neon.m4 (revision 7499)
> +++ build/ac-macros/neon.m4 (working copy)
> @@ -51,8 +51,8 @@
> case "$NEON_VERSION" in
> $NEON_WANTED_REGEX)
> echo "Using neon found in source directory."
> - SVN_NEON_INCLUDES=-'I$(abs_srcdir)/neon/src'
> - NEON_LIBS="\$(abs_builddir)/neon/src/libneon.la"

I'm not a shell expert, is the original code bash specific?

> + SVN_NEON_INCLUDES=-"I$abs_srcdir/neon/src"
> + NEON_LIBS="$abs_builddir/neon/src/libneon.la"

Your NEON_LIBS change doesn't appear to do the right thing, it means
that the NEON_LIBS= line in the generated Makefile has a hard-coded
path rather than $(abs_builddir).

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org