[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 7445 - trunk/subversion/libsvn_client

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-10-20 10:51:55 CEST

On Sat, Oct 18, 2003 at 06:15:53PM -0500, mbk@tigris.org wrote:
>...
> +++ trunk/subversion/libsvn_client/blame.c Sat Oct 18 18:15:50 2003
>...
> for (rev = lmb.eldest; rev; rev = rev->next)
> {
> const char *tmp;

You should be clearing the iterpool at the top of the loop. That pattern
is used to ensure that it always get cleared. In this particular change,
note that you won't clear the pool when last==NULL.

> SVN_ERR (svn_io_open_unique_file (&file, &tmp, "", ".tmp",
> - FALSE, subpool));
> - stream = svn_stream_from_aprfile (file, pool);
> + FALSE, pool));

The file should be created within the iterpool. Otherwise, you're creating
an unbounded number of files in the main pool (Badness).

>...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Oct 20 10:57:17 2003

This is an archived mail posted to the Subversion Dev mailing list.