Re: svn commit: rev 7438 - trunk/subversion/libsvn_client

On Sat, Oct 18, 2003 at 02:03:58AM +0100, Philip Martin wrote:
> > subpool = svn_pool_create (pool);
> > + diffpool = svn_pool_create (pool);
>
> Are two sub-pools really needed? Generally a function is expected to
> use the pool it is given, it only needs a sub-pool for iterations. Of
> the two, subpool looks to be redundant, given that it is never cleared
> within the function.

The distinction isn't really necessary. I've collapsed the two into
"iterpool", and made more use of the main pool.

> > + apr_pool_destroy (diffpool);
>
> It might be best to destroy diffpool at the end of the function...
[...]
> as then there will be no opportunity to use it after it has been
> destroyed.

Done (and fixed the cut-and-paste bug).

Committed in r7445.

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 19 01:20:20 2003