[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

empty_props_p: behaviour is OK so "###" is not needed?

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2003-10-17 16:23:13 CEST

Is this OK?

[[[
Resolve a "###" comment by re-wording it with lower expectations.

* subversion/libsvn_wc/props.c
  (empty_props_p): The current behaviour is OK, so document it as such rather
    than as deficient.
]]]

Index: subversion/libsvn_wc/props.c
===================================================================
--- subversion/libsvn_wc/props.c (revision 7429)
+++ subversion/libsvn_wc/props.c (working copy)
@@ -1224,12 +1224,12 @@
       else
         *empty_p = FALSE;

- /* ### really, if the size is < 4, then something is corrupt.
+ /* If the size is < 4, then something is corrupt.
          If the size is between 4 and 16, then something is corrupt,
          because 16 is the -smallest- the file can possibly be if it
- contained only one property. someday we should check for
- this. */
-
+ contained only one property. So long as we say it is "not
+ empty", we will discover such corruption later when we try
+ to read the properties from the file. */
     }

   return SVN_NO_ERROR;

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 17 16:22:45 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.