Re: [PATCH] automatic properties

Martin Furter <mf@rola.ch> writes:

> Yes, that works very well, only one issue remaining: i don't have the
> mimetype anymore which is used in the notify_func (f.ex. at the end of
> svn_wc_add):
>
> /* Report the addition to the caller. */
> if (notify_func != NULL)
> (*notify_func) (notify_baton, path, svn_wc_notify_add,
> kind,
> NULL, <--- this was mimetype
> svn_wc_notify_state_unknown,
> svn_wc_notify_state_unknown,
> SVN_INVALID_REVNUM);
>
> In import_file i can get it back because i have the hash containing the
> properties, but in svn_wc_add i can't.
> I could make a notify_func which stores the data in a baton and call the
> real notify_func after getting the auto-props.
>
> Or is it ok to use always NULL for mimetype ?

If I'm thinking of the right spot, using NULL is the difference
between seeing:

   A /some/path

and:

   A (bin) /some/path

In other words, we do use the mimetype to point out places where the
code has made an automatic decision about binariness (which effects
lots of things -- the ability to do contextual merging, ability to set
EOL properties, etc.)

Is this is a necessary feature? I have no strong opinions.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 1 15:16:25 2003