[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] cvs2svn.py multipath addition

From: Max Bowsher <maxb_at_ukf.net>
Date: 2003-09-30 15:20:03 CEST

Kim Lester wrote:
> Enclosed are the patches for multipath support in cvs2svn.py.

Thanks!

> Around half the changes are actually debugging lines that I used to help
> me figure out how the tool worked and I think they might as well stay
> for future use (use -d to turn them on).

I think it is a good idea, but it is a *seperate* idea. Please, only one
concept per patch.

Your patch also contains various unnecessary whitespace changes. If you feel
strongly that the code should be re-spaced, then make that a seperate patch,
please.

You sent your patch inline - it was linewrapped, and the indentation was
rather weird. Obviously this last is especially important for Python code
:-)

Please re-send your patch, taking account of the above.

Once these minor issues are out of the way, we can get to the interesting
bit - your new features!

Thanks again,

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 30 15:36:34 2003

This is an archived mail posted to the Subversion Dev mailing list.