[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 7223 - trunk/packages/rpm/mandrake-9.1

From: <kfogel_at_collab.net>
Date: 2003-09-29 05:28:31 CEST

Files <files@poetryunlimited.com> writes:
> > If you looked carefully, you would notice that people here have given
> > you a metric shitload of slack and enough guidance to land the Space
> > Shuttle.
>
> I think I'm only asking for a proofreader.

Shamim, the current arrangement obviously isn't making anyone happy,
least of all you. For whatever reason, your sense of the project
conventions has not matched that of all (or most) of the other
committers. Pre-commit proofreading sounds like the best solution, as
you imply above.

I was the person who originally offered you commit access for Mandrake
packaging [original mail included below], and given what HACKING says
about partial commit access...

  "How partial commit access is granted:
   
   A full committer sponsors the partial committer. Usually this means
   the full committer has applied several patches to the same area from
   the proposed partial committer, and realizes things would be easier if
   the person were just committing directly. Approval is not required
   from the full committers; it is assumed that sponsors know what
   they're doing and will watch the partial committer's first few commits
   to make sure everything's going smoothly."

... I think it's a fair interpretation that if things *aren't* going
smoothly, then the person who sponsored the commit access can, if all
else fails, revoke the commit access. I've done so.

You are not to blame in this situation, rather I am. Our project
guidelines are not always simple to follow, and it's up to the sponsor
to verify that the potential committer has a firm grasp of the
guidelines, *before* offering commit access. I did not do this, and
the result was a lot of pain and frustration for you. Instead of
having a chance to ramp up gradually, like most other committers, you
were put on the spot right away, with no training.

If I had waited to see some patches first, you would have been able to
fix the problems at your leisure, and the general irritation level for
everyone would have been lower because the changes wouldn't have gone
into the repository until they were vetted.

Please accept my apologies for putting you in this situation. Let's
go back to where this all should have started: you posting patches,
others reviewing them. When an individual patch looks good, someone
can commit it. (Of course, we can't promise that someone will always
have time for any particular patch... But that's always the case with
posted patches.)

-Karl

-------------------------------------------------
   From: kfogel@collab.net
   To: Michael Ballbach <ballbach@rten.net>
   Cc: dev@subversion.tigris.org, Greg Stein <gstein@lyra.org>
   Subject: Re: packages/rpm/mandrake9.1 files WAS: why patch build-outputs.mk in svn-install.patch
   References: <20030917.Ai9.15451200@phpgw.poetryunlimited.com>
           <20030917181336.GB10954@wayreth.rten.net>
           <1063860962.29508.54.camel@win95.home.islam.net>
           <20030918053437.GA20053@wayreth.rten.net>
   Reply-To: kfogel@collab.net
   Date: 18 Sep 2003 13:06:50 -0500
   
   Michael Ballbach <ballbach@rten.net> writes:
> (Greg: This gentlemen is interested in taking over the mandrake rpms,
> and as I've neglected them recently I'd like to take him up on it. If
> that is acceptable to you, could you set him up ? You could remove my
> commit access as well, if you'd like.)
   
   Greg can do this, as can a few other people. Files, if you're okay
   with it, just send your tigris.org username and some password
   (plaintext or crypted is fine) to
   
      Ben Collins-Sussman <sussman@collab.net>
      C. Michael Pilato <cmpilato@collab.net>
      Sander Striker <striker@apache.org>
      Greg Stein <gstein@collab.net>
      Karl Fogel <kfogel@collab.net>
   
   and one of us will set you up as a new Mandrake pkg maintainer.
   
   Thanks,
   -Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 29 06:19:08 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.