[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 7223 - trunk/packages/rpm/mandrake-9.1

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2003-09-29 04:28:05 CEST

Files wrote:

>>>There is a patch that's been floating around in this discussion. It
>>>modifies the javahl directory in the subversion/bindings/java.
>>>
>>>Since *I* don't own the patch, I simply added it so that at least a
>>>Mandrake JAVAHL RPM could be built. I will be removing it as soon as the
>>>patch is finalized.
>>
>>If the patch has not been committed by the maintainers of that code,
>>then it's probably because it is not yet ready. Adding it in to the
>>packaged versions you intend people to use is just short circuiting the
>>process we use to make changes to the software, and seems like a bad
>>idea to me.
>
>
> Excuse me Garret, but committing stuff to the trunk inherently feels
> wrong to me, so don't even get me started. But I for one, have no
> choice.

What are you talking about? Again we seem to have some kind of
missunderstanding. Committing changes to the trunk is the way things
are done in this project. We have an unstable trunk policy. Changes
are made there so that they get as much visability as possible. The
only time we make changes on a branch is when they will be destabalizing
in a major way. That said, changes don't just go into the trunk on a
whim, that's why we have this whole process of mailing changes around on
the dev list and reviewing them, to ensure that they meet a minimum
level of quality before they are put out there for the world to use.
The patch you added to the RPM for the javahl short circuits that
process, and that's a bad thing.

> Second. I have been helping the people working on the java patch to make
> sure it compiles under Mandrake. Surely you could reconsider your harsh
> words and your JUDGEMENTS in light of the fact that you yourself
> neglected to read why this thing was being worked on in the first place?

Great, it's good to see that you're working with the authors of that
patch, but that doesn't mean you can just dump it into your packages
before it goes into the trunk. And as for me reconsidering any
judgements, dream on. I'm giving you advice based on my experience with
this project, and I feel perfectly justified in doing so. There's no
requirement that I be personally working on a given part of the system
to express an opinion, if that was true than we would all be worse off,
as much of the best review material comes from people who are not
directly working on something.

> Third, we don't have a production branch. Everyone got upset just
> because I wanted to create a branch to test RPMs in and now you're going
> to beat me over the head with this one?

I have no idea what you're talking about here.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 29 04:28:56 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.