Re: svn commit: rev 7223 - trunk/packages/rpm/mandrake-9.1

Files <files@poetryunlimited.com> writes:

> Done - copy follows
> ----------------------------------------------------------------------------------------------------------------------------------------
> rev 7223: kellin | 2003-09-27 23:48:24 -0400 (Sat, 27 Sep 2003) | 51
> lines

When the change is spread over several files then start with a brief
(one sentence, perhaps two) overview of the change.

"Update Madrake package build to add support for Java." or whatever
this change did.

> * 46_mod_dav_svn.conf

* packages/rpm/mandrake-9.1/46_mod_dav_svn.conf

The HACKING guidelines say to use full path names, the other log
messages use full path names, you should use full path names.

> (dav_svn_module,authz_svn_module): moved to <apache>-extramodules
> for Mandrake reqs.
>
> * fop-file
> * fop-gz
> * fop-bz2
> * fop-installed
> Fop detection routines

Rev 7223 didn't change fop-gz, fop-bz2 or fop-installed, they should
not be mentioned.

* packages/rpm/mandrake-9.1/fop-file: Ignore ls error output.

>
> * ge
> * ge-0-30-0
> * increment-revision
> * just-docs: obsoleted by eq1
> * eq1
> * full-machine-name
> Conditional detection and naming scripts

* packages/rpm/mandrake-9.1/ge: Renamed to ge-0-30-0
* packages/rpm/mandrake-9.1/ge-0-30-0: Renamed from ge

I'm guessing that's what happened, your log message should tell me.

* packages/rpm/mandrake-9.1/just-docs: Removed, obseleted by eq1.
* packages/rpm/mandrake-9.1/eq1: New file.

Neither increment-revision nor full-machine-name appear to have
changed in r7223, they should not be mentioned.

>
> * machine-name
> * make-fo-patch
> * make-version-patch
> Static patch collector scripts

* packages/rpm/mandrake-9.1/make-version-patch: Lots of things
  changed, I'm sure you can tell me why.

machine-name and make-fo-patch don't appear to have been modified in
rev 7223, they should not be mentioned.

>
> * subversion.rc
> Default macros

Didn't change in r7223, should not be mentioned.

>
> * README
> (added entries): Added entries describing the current changes. More
> data will follow on modifications made and the options available in
> the
> new Makefile

Didn't change in r7223, should not be mentioned.

>
> * subversion.spec
> (heavy rewrite): See email shortly
>
> * svn-book-fop-ge-0-30-0.patch
> * svn-book-fop.patch
> * svn-book.patch
> * svn-fo.patch
> * svn-install.patch

These didn't change in r7223, they should not be mentioned.

> * svn-install-silent-ge-0-31-0.patch

* packages/rpm/mandrake-9.1/svn-install-silent-ge-0-31-0.patch: New
  file containing patches to Makefile.in and gen-make.py.

> * svn-install-silent-ge-0-30-0.patch
> * svn-install-silent.patch

These didn't change in r7223, they should not be mentioned.

> * svn-java.patch

* packages/rpm/mandrake-9.1/svn-java.patch: New file, containing patch
  to the Java bindings.

>
> Context sensitivie patches for build process to sync with Mandrake
> reqs.
>
> * Makefile
> (heavily modified): See email shortly
>
> Shamim Islam 9/27/03

Can you explain why mandrake-9.1 has been changed but not 9.0 or 9.2?

I'm not really interested in Mandrake or Java, I tend to ignore the
dev list emails about them. As far as I can tell you have added some
sort of Java patch (fairly large) to the Madrake build. What does it
do? Did you write it? Did someone else? I should be able to tell
from the log message, just a single sentence summary will do.

I must admit I don't understand why you need to make such extensive
changes to the build system in order to build Mandrake packages.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org