[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 7225 - in trunk: . build/ac-macros

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-09-28 23:06:50 CEST

Erik Huelsmann wrote:

>I submitted it to the list maybe 15 minutes before you committed. [ I did
>not see the mail myself yet... wondering why ] So by then you were probably
>running a compile to test your changes....
>
>About the patch: No problem, you can find it at the end of this mail.
>
>
[snip]

>Index: configure.in
>===================================================================
>--- configure.in (revision 7224)
>+++ configure.in (working copy)
>@@ -121,8 +121,8 @@
>
> dnl verify apr version and set apr flags
> changequote(<<, >>)
>-APR_VER_REGEX="0\.9\.[4-9]"
>-APU_VER_REGEX="0\.9\.[4-9]"
>+APR_VER_REGEX="0\.9\.[4-9]\|1\.0\.0"
>+APU_VER_REGEX="0\.9\.[4-9]\|1\.0\.0"
> changequote([, ])
>
> SVN_LIB_APR($APR_VER_REGEX)
>
>
Aha! I suspected your patch would do something like this. :-)
Unfortunately, that woun't work; those regular expressions are tested
with 'expr', which does not understand the | operator (at least, it
doesn't on FreeBSD). In fact, the first thing I tried was exactly what
you did here.

We could use 'grep' instead of 'expr'. Does anyone know why we don't?

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Sep 28 23:07:27 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.