[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Log message warning

From: D.J. Heap <dj_at_shadyvale.net>
Date: 2003-09-27 03:52:00 CEST

Updated to Subversion's guidelines after CMike's comments.

Here's a fix to the log message warning when \'s are used instead of /'.
  (Fixes the failing log test on Windows)

Log:

Fix 'svn commit -F A\B\C' (paths use \ rather than / on Windows) so
that the file path is translated before being passed to the APIs.

* subversion/clients/cmdline/main.c
   (main) Add a missing call to svn_path_internal_style so that the
   log message file can be recognized as versioned and a warning
   given as needed.

Index: subversion/clients/cmdline/main.c
===================================================================
--- subversion/clients/cmdline/main.c (revision 7208)
+++ subversion/clients/cmdline/main.c (working copy)
@@ -708,11 +708,13 @@
         {
           svn_wc_adm_access_t *adm_access;
           const svn_wc_entry_t *e;
+ const char *filename_utf8 = svn_path_internal_style (utf8_opt_arg,
+ pool);
 
- err = svn_wc_adm_probe_open (&adm_access, NULL, utf8_opt_arg, FALSE,
- FALSE, pool);
+ err = svn_wc_adm_probe_open (&adm_access, NULL, filename_utf8,
+ FALSE, FALSE, pool);
           if (! err)
- err = svn_wc_entry (&e, utf8_opt_arg, adm_access, FALSE, pool);
+ err = svn_wc_entry (&e, filename_utf8, adm_access, FALSE, pool);
           if ((err == SVN_NO_ERROR) && e)
             log_under_version_control = TRUE;
           if (err)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Sep 27 03:52:41 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.