"D.J. Heap" <dj@shadyvale.net> writes:
> Log:
>
> Fix 'svn commit -F A\B\C' so that the file path is translated before
> being passed to the APIs.
You might want to mention the Windows-only-ness of this *in* the log
message.
> * subversion/clients/cmdline/main.c
> (main) Add a missing call to svn_path_internal_style so that the
> file can be recognized as versioned and a warning given as needed.
"the file"? What file?
> Index: subversion/clients/cmdline/main.c
> ===================================================================
> --- subversion/clients/cmdline/main.c (revision 7208)
> +++ subversion/clients/cmdline/main.c (working copy)
> @@ -708,11 +708,12 @@
> {
> svn_wc_adm_access_t *adm_access;
> const svn_wc_entry_t *e;
> + const char* filename_utf8 = svn_path_internal_style (utf8_opt_arg, pool);
I'm being picky here, but we use "type-space-asterisk-varname" instead
of "type-asterisk-space-varname", generally. So, "const char *filename_utf8".
Also, I *know* you weren't planning to introduce lines of code that
were 80 columns or longer.
>
> - err = svn_wc_adm_probe_open (&adm_access, NULL, utf8_opt_arg, FALSE,
> + err = svn_wc_adm_probe_open (&adm_access, NULL, filename_utf8, FALSE,
> FALSE, pool);
> if (! err)
> - err = svn_wc_entry (&e, utf8_opt_arg, adm_access, FALSE, pool);
> + err = svn_wc_entry (&e, filename_utf8, adm_access, FALSE, pool);
> if ((err == SVN_NO_ERROR) && e)
> log_under_version_control = TRUE;
> if (err)
And I *really know* you weren't going to make that mistake more than
once. :-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Sep 27 03:26:52 2003