Re: svn commit: rev 7174 - in trunk/subversion: clients/cmdline include libsvn_client libsvn_ra_dav

Ben Collins-Sussman <sussman@collab.net> writes:

>> svn_auth.h should document this fact as the values now matter and
>> changing them has consequences.
>
> We already have these lines in libsvn_client/auth.c:
>
> /* The keys that will be stored on disk */
> #define SVN_CLIENT__AUTHFILE_ASCII_CERT_KEY "ascii_cert"
> #define SVN_CLIENT__AUTHFILE_FAILURES_KEY "failures"
>
>
> Perhaps all such macros should be moved into svn_auth.h instead?

Maybe. Either way, svn_auth.h should document that the
SVN_AUTH_SSL_XXX values are stored on disk--if someone were to reorder
them, or insert a new one, it could silently alter the decision the
user made when accepting the cert.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org