Quoting John Peacock <jpeacock@rowman.com>:
> Branko ÄŒibej wrote:
> > Your patch won't compile at all on Windows, because you're calling
> > umask, setuid and setgid directly. You'll have to come up with a
> > portable implementation of those functions (possibly in APR).
>
> APR doesn't currently have anything comparable.
I suspected as much. It should be fairly easy to implement them, though.
> Apache code itself
> calls all
> three of those directly as well, though not within Win32 code
> presumably. I was
> hoping there was a compatibility library which would stub out those
> calls as not
> relevant to the Win32 security model.
>
> Since the issue this patch was intended to solve, easy creation of
> appropriately
> owned and chmod'd repositories, is only an issue under *nix-like O/S's,
> would
> the appropriate solution to #ifdef the code out under Win32, or to try
> and
> emulate the bits that map?
I suppose an #ifdef would be appropriate in this case, at least temporarily, as
long as it's carefully localized. I'd suggest just ignoring the option on
Windows, not removing the option itself. The option's docstring should indicate
that it's a no-op on non-Unix systems.
Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 16 15:13:12 2003