Shun-ichi GOTO <gotoh@taiyo.co.jp> writes:
> Hi,
>
> I have some patch for psvn.el and some suggestions.
>
> Suggestions:
>
> * Currently keymap of `svn-status-unset-all-usermarks' is * !
> but `svn-status-show-svn-diff-for-marked-files' is assigned to
> C-=. I think * u is better for
> `svn-status-show-svn-diff-for-marked-files'. Or, like other
> dired style mode, I like M-DEL for `svn-status-unset-all-usermarks'.
> I like M-DEL, and attached patch contains this.
>
> * Currently `svn-prop-edit-done' is run asynchronously. But I think
> it should to be synchronous because it splits operations per
> directories and prompts us for every operations. if asynchronous,
> it show prompt immediately after last prompt although last operation
> is not completed. Then it cause error if we answered while last
> operation is still active.
>
> My patch attached bellow is trivial one for synchronous
> operation. `svn-prop-edit-done' is still same to original
> (asynchronous) one. New function `svn-prop-edit-do-it' is added and
> it takes 'async' flag argument. Tow function using
> svn-prop-edit-done: `svn-status-property-ignore-file-extension' and
> `svn-status-property-ignore-file' were modified to run as
> synchronous. Other function using `svn-prop-edit-done' is not
> modified yet.
>
> * Some old emacsen does not support 3rd arg of add-to-list.
> I'm using psvn.el on emacs 20.7 (Meadow 1.15) except this.
>
> * Known BUG:
> We cannot do operation in hidden mode (hiding unmodified files),
> ex. property setting. I don't have patch yet.
>
> Patch:
>
> * psvn.el (svn-prop-edit-done): Bug fix of paren.
> (svn-prop-edit-do-it): New function splitted from
> `svn-prop-edit-done' to take arg for async/sync.
> (svn-status-property-ignore-file-extension): Use synchronous operation.
> (svn-status-property-ignore-file): Likewise.
> (svn-status-get-specific-revision): Do not use 3rd arg of add-to-list
> for old emacsen.
> (TOP): Define key M-DEL as `svn-status-unset-all-user-mark'.
>
Thanks for your suggestions and for your patch!
I will apply your patch soon.
What do you mean with the Known BUG:
> We cannot do operation in hidden mode (hiding unmodified files),
> ex. property setting. I don't have patch yet.
You can just unhide the files and start the operation then.
Or did I understand something wrong here?
Stefan.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 12 10:06:12 2003