[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: cvs2svn change_path crash

From: Faller, Gyula <GFaller_at_Graphisoft.hu>
Date: 2003-09-11 14:05:07 CEST

        Hi,

 I examined the script and I found that the problem is with the
 lazy use of and mixing path separators and slashes.
 It is working (but not OK) on unix but is not working on other systems.
 The script regards the whole directory tree as a flat directory
 with file names like \\dir1\dir2\\...\\filen.c and then
 maintain a dictionary for every directory (in this case single instance) with
 the entries in it.
 The immediate problem in the change_path function is when this directory
 is serialized with the dumps () function and then tried to assign to the
 self.nodes_db, the db throws an exception.

 line 679 of cvs2svn:
    self.nodes_db[parent_key] = marshal.dumps(parent)

 It means there is a limit on the field size of the db, and this string
 reach it.

 But it means on the other hand, if the conversion succeeded, there is no use
 of the generated svn repository with flat directory inside paths as file names.
 It is not possible to check it out.

 To make it working one should scan the cvs2svn.py code and exchange all '/' to os.sep.
 The other way (change all separators to '/') is not perfect because on some operating system
 the '/' can be a valid filename element.

        Gyula

> -----Original Message-----
> From: Michael Wood [mailto:mwood@its.uct.ac.za]
> Sent: csütörtök 2003. szeptember 11. 10:00
> To: Branko Cibej
> Cc: Max Bowsher; Faller, Gyula; dev@subversion.tigris.org
> Subject: Re: cvs2svn change_path crash
>
>
> On Thu, Sep 11, 2003 at 09:48:23AM +0200, Branko Čibej wrote:
> > Michael Wood wrote:
> >
> [snip]
> > >If he upgrades he will have to recompile the Subversion Python
> > >bindings against Python 2.3.
> > >
> > >
> > Not if he uses the 0.29.0 binaries.
>
> Ahhh. I didn't notice you'd upgraded your machine to Python 2.3 :)
>
> --
> Michael Wood <mwood@its.uct.ac.za>
>
Received on Thu Sep 11 14:05:50 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.